Skip to content

OTT-918 php warning for laravel shortcodes #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nazar-boyko-vshred
Copy link

No description provided.

@andyov17
Copy link

The view data fix (a9c2295) in this PR works well
if you're using another view factory (Flux in my case), the view data was being overwritten, and so the context was lost

@foreach($foo as $bar)
    [firstShortcode] {{-- $bar exists--}}
    <flux:fieldset></flux:fieldset> {{-- sets it's own data --}}
    [secondShortcode {{-- $bar missing as flux set data --}}
@endforeach

@andyov17
Copy link

@nazar-boyko-vshred could you please merge master into this so it supports later Laravel versions as it was forked form quite an old version? Then this branch could be used until it's been approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants