Skip to content

[benchmark][structured output] Add offline benchmark script for structured output #17437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

lk-chen
Copy link
Collaborator

@lk-chen lk-chen commented Apr 30, 2025

  • Reuse some flags from serving version
  • Tested that serving benchmark still work in V0
    • V1 serving benchmark is broken, but it was already broken on main branch
  • Tested that offline benchmark work in V0/V1
  • updated run_structured_ouput_benchmark.sh to allow config QPS_VALUES

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented Apr 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @lk-chen.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

lk-chen added 3 commits April 29, 2025 20:56
Signed-off-by: Linkun Chen <github@lkchen.net>
Signed-off-by: Linkun Chen <github@lkchen.net>
Signed-off-by: Linkun Chen <github@lkchen.net>
@lk-chen lk-chen force-pushed the bench_struct_output branch from 2096883 to 00be71d Compare April 30, 2025 03:57
@mergify mergify bot removed the needs-rebase label Apr 30, 2025
Signed-off-by: Linkun Chen <github@lkchen.net>
Copy link

mergify bot commented Apr 30, 2025

⚠️ The sha of the head commit of this PR conflicts with #17440. Mergify cannot evaluate rules on this PR. ⚠️

@lk-chen lk-chen deleted the bench_struct_output branch April 30, 2025 04:11
@lk-chen lk-chen restored the bench_struct_output branch April 30, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant