Skip to content

add more pytorch related tests for torch nightly #17422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 2, 2025

Conversation

yangw-dev
Copy link
Collaborator

@yangw-dev yangw-dev commented Apr 29, 2025

Tests needed for vllm against torch nightly:

  • PyTorch compiler tests
  • basic model tests
  • Quantization tests

Testing build with vllm/ change
https://buildkite.com/vllm/ci/builds/18950

Mock tests:
Add some comment in vllm/ path: quantization is blocked, which is expected, the test block Build torch nightly image shows in normal nightly

image

Testing nightly run:
https://buildkite.com/vllm/ci/builds/18955

No blocking which is expected
image

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yangw-dev yangw-dev requested a review from khluu April 29, 2025 23:27
@mergify mergify bot added the ci/build label Apr 29, 2025
@yangw-dev yangw-dev changed the title add more tests for torch nightly add more pytorch related tests for torch nightly Apr 29, 2025
Copy link

mergify bot commented Apr 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yangw-dev.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 29, 2025
@yangw-dev yangw-dev force-pushed the addMoreTorchNightlyTest0429 branch from f678b98 to 1fea3e4 Compare April 29, 2025 23:41
@mergify mergify bot removed the needs-rebase label Apr 29, 2025
@yangw-dev yangw-dev marked this pull request as ready for review April 30, 2025 20:39
@yangw-dev yangw-dev requested a review from zou3519 April 30, 2025 23:00
Copy link

mergify bot commented May 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yangw-dev.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 1, 2025
Copy link
Collaborator

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for test-pipeline.yaml and the dependencies

Copy link
Collaborator

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@mergify mergify bot removed the needs-rebase label May 1, 2025
@yangw-dev yangw-dev force-pushed the addMoreTorchNightlyTest0429 branch from 85f79d1 to db89d56 Compare May 1, 2025 17:03
Copy link

mergify bot commented May 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yangw-dev.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 1, 2025
yangw-dev added 8 commits May 1, 2025 10:05
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev yangw-dev force-pushed the addMoreTorchNightlyTest0429 branch from db89d56 to 237c8be Compare May 1, 2025 17:06
@mergify mergify bot removed the needs-rebase label May 1, 2025
yangw-dev added 2 commits May 1, 2025 10:07
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2025
@vllm-bot vllm-bot merged commit b8b0859 into vllm-project:main May 2, 2025
96 of 99 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants