Skip to content

Remove Zephyr 7B from everywhere possible in CI #17401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 29, 2025

tests/entrypoints/openai/test_completion.py is the exception because it has LoRA and PromptAdapters. This can also be removed once we drop PromptAdapters.

`tests/entrypoints/openai/test_completion.py` is the exception because it has LoRA and PromptAdapters. This can also be removed once we drop PromptAdapters.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, good if green!

@hmellor hmellor enabled auto-merge (squash) April 29, 2025 17:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
hmellor added 2 commits April 29, 2025 21:03
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Copy link
Member Author

hmellor commented Apr 29, 2025

TinyLlama is based on an early version of Llama with max context length 2048... Lots of tests specify 8192 😭

I'll have a go at making my own LoRA based on a smaller model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed structured-output
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants