Skip to content

Fix appending of Interstitials in place that exceed X-PLAYOUT-LIMIT #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 16, 2025

This PR will...

Limit append-in-place buffering to playout-limit.

Why is this Pull Request needed?

Buffering of interstitial assets was not stopped when the forward buffer past X-PLAYOUT-LIMIT. This is expected when each asset player resets the media source and X-PLAYOUT-LIMIT is enforced by monitoring currentTime.

When all assets are appended in place, sharing a single MediaSource, buffering must stop after reaching or exceeding the playout limit, so that the MediaSource can be transferred to the hls instance responsible for buffering the next scheduled segment.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #7179

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch force-pushed the bugfix/playout-limit-append-in-place branch from be70bcc to 1c7fdb5 Compare April 16, 2025 00:28
@martmol
Copy link
Collaborator

martmol commented Apr 16, 2025

Tested this PR and it's fixing (partially) the bug (When not on livepoint) 🚀 Two things;

  • I noticed that sometimes the interstitial continues for a bit (up to couple of seconds) after INTERSTITIAL_ENDED was triggered, probably playing the last buffered bit.
  • When on live point, INTERSTITIAL_ENDED is triggered but interstitial continues to play. Is this because the X-PLAYOUT-LIMIT isn't known when the interstitial starts playing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

X-PLAYOUT-LIMIT not respected when append in place is enabled
2 participants