Skip to content

Unused Packer Options Cleanup #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Unused Packer Options Cleanup #2976

wants to merge 5 commits into from

Conversation

yenjames
Copy link

@yenjames yenjames commented Apr 14, 2025 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  1. alpha, beta: These are called alpha_clustering, beta_clustering in front-end option parsing, but alpha, beta within packer. Standardized name to timing_gain_weight and connection_gain weight for front-end option, packer, and documentation.
  2. global_clocks: Can't be set by user anyways, always set to true.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@yenjames yenjames self-assigned this Apr 14, 2025
@yenjames yenjames linked an issue Apr 14, 2025 that may be closed by this pull request
[Pack] Unused Packer Options #2964
Open
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Apr 14, 2025
yenjames added 3 commits April 27, 2025 14:28
@yenjames
initial documentation
797e969
@yenjames
Standardized and renamed packer alpha and beta variable. They are now…
d3f1dba 
… referred to as timing_gain_weight and connection_gain_weight, used as a weight parameter during timing and connection driven clustering respectively.
@yenjames
Removed new doc for inter_cluster_net_delay and auto_compute_inter_cl…
46964db 
…uster_net_delay. TODO: remove those vars from read_options.h and online documentation.
@yenjames yenjames force-pushed the jy-pack-option-cleanup branch from de69bcb to 46964db Compare April 27, 2025 18:40
@github-actions github-actions bot added the docs Documentation label Apr 27, 2025
vaughnbetz
vaughnbetz approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks James -- very clean code!

vpr/src/base/vpr_types.h
* circuit's resource requirements)
* @param timing_update_type
* Controls how timing analysis updates are performed. (Default: auto)
* @param use_attraction_groups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this option is unused. Please check that, and if it is unused, delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz approved these changes

Assignees

@yenjames yenjames

Labels
docs Documentation lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pack] Unused Packer Options
2 participants
@yenjames @vaughnbetz