Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes fasm warnings mentioned in this issue. It also replaces some std::string and const std::string& arguments with std::string_view. When an rvalue char* is passed as an std:string& argument, an std::string object needs to be constructed, which involves memory allocation and copying. std::string_view doesn't need to allocate memory and copy the null terminated string because it directly points to rvalue char*.
Types of changes
Checklist: