Skip to content

Fix fasm warnings #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Fix fasm warnings #2535

merged 5 commits into from
Apr 15, 2024

Conversation

soheilshahrouz
Copy link
Contributor

This PR fixes fasm warnings mentioned in this issue. It also replaces some std::string and const std::string& arguments with std::string_view. When an rvalue char* is passed as an std:string& argument, an std::string object needs to be constructed, which involves memory allocation and copying. std::string_view doesn't need to allocate memory and copy the null terminated string because it directly points to rvalue char*.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code lang-make CMake/Make code libvtrutil blifexplorer labels Apr 15, 2024
@vaughnbetz vaughnbetz merged commit 3e8d605 into master Apr 15, 2024
100 checks passed
@vaughnbetz vaughnbetz deleted the fix_fasm_warnings branch April 15, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blifexplorer lang-cpp C/C++ code lang-make CMake/Make code libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants