✨(backend) support _FILE environment variables for secrets
#912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyouzpanda
force-pushed
the
feature/environment-variables-file
branch
2 times, most recently
from
88c3c56 to
98a7eaa
Compare
soyouzpanda
force-pushed
the
feature/environment-variables-file
branch
from
98a7eaa to
d47c362
Compare
lunika
reviewed
Apr 29, 2025
| @@ -37,6 +37,34 @@ def get_release(): | |||
| except (FileNotFoundError, KeyError): | |||
| return "NA" # Default: not available | |||
|
|
|||
| class SecretFileValue(values.Value): | |||
There was a problem hiding this comment.
tests are missing to validate this new class.
There is no docstring explaining how to use it
There is no documentation at all.
|
I suggest to add this in https://github.com/suitenumerique/django-lasuite/ As you are doing nix packages for all projects, you will need it everywhere. Instead copy/pasting it, do it in the Thanks |
Should I wait that the PR suitenumerique/django-lasuite#15 is merged ? (I think so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #909