fix: resolve hash mismatches when uploading files #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bastiandoetsch
approved these changes
Apr 17, 2025
|
Please don't merge these changes yet. I'm trying to reproduce the original mismatch issue first before merging this change. So far I'm not successful with the description above. |
PeterSchafer
requested changes
Apr 23, 2025
PeterSchafer
force-pushed
the
fix/bundle-utf8-encode-file-content
branch
2 times, most recently
from
e5f7c6c to
2663ed7
Compare
PeterSchafer
force-pushed
the
fix/bundle-utf8-encode-file-content
branch
from
2663ed7 to
187f835
Compare
PeterSchafer
approved these changes
Apr 30, 2025
PeterSchafer
force-pushed
the
fix/bundle-utf8-encode-file-content
branch
from
b427bc5 to
6e1860f
Compare
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picked from #94 to resolve hash mismatches when uploading files to the files-bundles-store. The changes just ensure the file content we send to the files-bundle-store is UTF8 encoded.
If you want to reproduce the hash mismatches using the CLI you can use this fixture (if you want to retrigger a mismatch after the file was uploaded successfully, just make some small content changes to the file content). Tested this manually with the CLI, not sure yet on how to test this 🤔
Checklist
🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.Ref: CLI-777, CLI-871