Improve failed phpt test diff #6191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of multiline placeholder %a or %A we try to match multiple lines at the same time. The tricky part is to keep the expected output and the real output in sync since they can be different in size and amount of lines. Co-authored-by: Volker Dusch <github@wallbash.com> Co-authored-by: Sebastian Feldmann <sf@sebastian-feldmann.info>
sebastianfeldmann
force-pushed
the
improve-phpt-failed-diff-output
branch
from
fa184aa to
8243458
Compare
sebastianbergmann
added
type/bug
|
I think this is a bug fix and as such should go into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of multiline placeholder %a or %A we try to match multiple lines at the same time.
The tricky part is to keep the expected output and the real output in sync since they can be different in size and amount of lines.