chore(page): updated examples to provide a11y labels #11741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11741.surge.sh A11y report: https://patternfly-react-pr-11741-a11y.surge.sh |
thatblindgeye
requested changes
Apr 21, 2025
| <p> | ||
| Body text should be Red Hat Text at 1rem(16px). It should have leading of 1.5rem(24px) because <br /> | ||
| of its relative line height of 1.5. | ||
| </p> | ||
| </Content> | ||
| </PageSection> | ||
| <PageSection>Panel section content</PageSection> | ||
| <PageSection aria-label="Panel section content">Panel section content</PageSection> |
There was a problem hiding this comment.
Let's remove "content' from the label so that it'll be "Panel section" that contains the "panel section content"
| @@ -325,13 +325,13 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => { | |||
| mainContainerId={mainContainerId} | |||
| isBreadcrumbWidthLimited | |||
| > | |||
| <PageSection isWidthLimited> | |||
| <PageSection isWidthLimited aria-label="Main title"> | |||
There was a problem hiding this comment.
Similar as th eother PR, let's point to the Content component's id in an aria-labelledby instead
Mash707
force-pushed
the
page-update-examples-to-provide-a11y-labels-part-two
branch
from
05475c3 to
67fa302
Compare
|
I have made the necessary changes. Let me know what you think. |
nicolethoen
approved these changes
Apr 28, 2025
thatblindgeye
approved these changes
Apr 28, 2025
Mash707
deleted the
page-update-examples-to-provide-a11y-labels-part-two
branch
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11740
Towards #10173
I have divided the issue into 2 PRs to make it easier for reviewing