Skip to content

Removing broken link in cookbook example #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Removing broken link in cookbook example #1794

merged 2 commits into from
Apr 29, 2025

Conversation

robtinn
Copy link
Contributor

@robtinn robtinn commented Apr 25, 2025

Summary

I picked up this github issue that noticed a broken link in the cookbook website.

Motivation

It would tidy up the cookbook a bit to remove/fix this broken link.

It appears that linking to a .py file is not supported for cookbook.openai.com as all the other files in the examples folder are .ipynb, so I thought best to remove this link. Alternatively we could specify the github url to the api_request_parallel_processor.py file but I thought simply removing this link would be better because the location/name of this file is likely to change in the future.

@pap-openai
Copy link
Contributor

Interesting one, thanks for this @robtinn! – the link works on https://github.com/openai/openai-cookbook/blob/main/examples/Embedding_Wikipedia_articles_for_search.ipynb but doesn't work on the cookbook website as we don't render .py files. I'm wondering if we should redirect to github in the back-end/render if the link isn't .md / .ipynb instead of removing the link, any thoughts?

Copy link

@prashantmital-openai prashantmital-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the link outright, we should fix the link instead. I think supplying the full GitHub link to the script should be fine: https://github.com/openai/openai-cookbook/blob/main/examples/api_request_parallel_processor.py

@robtinn
Copy link
Contributor Author

robtinn commented Apr 28, 2025

Thanks both, I just updated the link for now to the GitHub link.

@robtinn robtinn merged commit 5d64d5d into main Apr 29, 2025
@robtinn robtinn deleted the rtinn/link_fix branch April 29, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants