Fix elements sometimes being visible from other dimensions in the current dimension #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245 (and maybe #4165?)
The bug is that the player's dimension changes after one second, but during that time not all vehicles have been streamed-in yet. As a result, some vehicles get streamed while the player is already in the new dimension. If for example, increase the delay in the test script attached to the mentioned issue, the problem no longer occurs because all vehicles have already been streamed.
The solution is to cancel the streaming of an element if the element's dimension is different from its streamer's dimension (e.g., vehicle streamer)