Skip to content

More static maps #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

More static maps #4164

merged 3 commits into from
May 6, 2025

Conversation

roystgnr
Copy link
Member

@roystgnr roystgnr commented May 5, 2025

One last feature pulled out of #4150

roystgnr added 3 commits May 5, 2025 14:27
@roystgnr
Add more static Elem::type_to_*_maps
4e39469 
I don't think these will become obsolete the way the ones assuming
fixed element topology did, and they're much better than calling e.g.
Elem::build(type)->dim()
@roystgnr
Add unit tests for new Elem::type_to_* maps
1d9a0cc
@roystgnr
Use new Elem::type_to_foo_maps in unit tests
06e8786
@moosebuild
Copy link

Job Coverage, step Generate coverage on 06e8786 wanted to post the following:

Coverage

a8a242 #4164 06e878
Total Total +/- New
Rate 63.41% 63.42% +0.01% -
Hits 74840 74848 +8 0
Misses 43177 43169 -8 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

jwpeterson
jwpeterson approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@jwpeterson jwpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the unit test will catch the case where someone adds a new element type but forgets to update the type_to_default_order_map? If so, 👍

@roystgnr
Copy link
Member Author

roystgnr commented May 6, 2025

It will (combined with -Werror on semirecent compilers, at least) when someone remembers to INSTANTIATE_ELEMTEST(THEIR_NEW_ELEM_TYPE). I'm actually not sure how to ensure that, though. The unit tests are supposed to be runnable independently and selectively, so it's hard to distinguish between "the author forgot to add a unit tests instantiation for ElemType t" and "there's an instantiation but the user used a --re Foo option that skipped it".

@roystgnr roystgnr merged commit 7726ab0 into libMesh:devel May 6, 2025
20 checks passed
@roystgnr roystgnr deleted the more_static_maps branch May 6, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwpeterson jwpeterson jwpeterson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roystgnr @moosebuild @jwpeterson