Skip to content

feat: Add ExecuteEx::replace_arguments #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: Add ExecuteEx::replace_arguments #3842

wants to merge 1 commit into from

Conversation

lu-zero
Copy link

@lu-zero lu-zero commented Apr 24, 2025

Does your PR solve an issue?

Closes #3839

Is this a breaking change?

No, it adds a new trait and a new method.

@abonander
Copy link
Collaborator

Execute::take_arguments is not meant for general use and I have plans to delete the entire trait in the next release: #3723 (comment)

I'd accept the addition of a getter for arguments to Query and related structs. You could then just .clone() the arguments.

@abonander abonander closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a replace_arguments dual to `take_arguments
2 participants
@lu-zero @abonander