Skip to content

Adding updates to vue starter kit favicons #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added public/apple-touch-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/favicon.ico
Binary file not shown.
3 changes: 3 additions & 0 deletions public/favicon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion resources/js/components/AppHeader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const rightNavItems: NavItem[] = [
},
{
title: 'Documentation',
href: 'https://laravel.com/docs/starter-kits',
href: 'https://laravel.com/docs/starter-kits#vue',
icon: BookOpen,
},
];
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/AppSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const footerNavItems: NavItem[] = [
},
{
title: 'Documentation',
href: 'https://laravel.com/docs/starter-kits',
href: 'https://laravel.com/docs/starter-kits#vue',
icon: BookOpen,
},
];
Expand Down
4 changes: 4 additions & 0 deletions resources/views/app.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@

<title inertia>{{ config('app.name', 'Laravel') }}</title>

<link rel="icon" href="/favicon.ico" sizes="any">
<link rel="icon" href="/favicon.svg" type="image/svg+xml">
<link rel="apple-touch-icon" href="/apple-touch-icon.png">

<link rel="preconnect" href="https://fonts.bunny.net">
<link href="https://fonts.bunny.net/css?family=instrument-sans:400,500,600" rel="stylesheet" />

Expand Down