Skip to content

fix(eap-spans): span-samples endpoint always returns dataset=spansIndexed, set sampling mode #90546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix(eap-spans): span-samples endpoint always returns dataset=spansIndexed, set sampling mode #90546

merged 1 commit into from
Apr 29, 2025

Conversation

DominikB2014
Copy link
Contributor

  1. set sampling mode if provided by snuba params
  2. ensure the dataset param is properly set in the meta of the response

@DominikB2014 DominikB2014 requested a review from a team as a code owner April 28, 2025 20:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 28, 2025
@DominikB2014 DominikB2014 merged commit 9ed71ad into master Apr 29, 2025
65 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-403-add-sampling-mode-to-span-sampling-endpoint branch April 29, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmak wmak wmak approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikB2014 @wmak