feat(vertexai): Allow serializing to Developer API models #17294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move parsing from top level methods, and serialization from a method on the model,into instance methods on a new `SerializationStrategy` class. Use the existing parsing code for the vertex strategy and copy over code form the developer SDK for the Google AI strategy. Add a `_ModelUri` class to allow a vertex and developer specialization for the different backends. Copy the serialization and parsing tests from the developer SDK, skip a few tests that rely on arguments or methods that are unsupported in the vertex model. Tests skipped for content embedding and extra arguments passed to countTokens.
natebosch
commented
Apr 21, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/base_model.dart
Outdated
Show resolved
Hide resolved
Remove some tests that were added testing behaviors moved to new private classes. These details are still tested in other places.
natebosch
changed the title
|
I think the remaining CI failures are unrelated to this change. |
cynthiajoan
reviewed
Apr 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/developer/api.dart
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Apr 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/base_model.dart
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Apr 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/base_model.dart
Outdated
Show resolved
Hide resolved
cynthiajoan
approved these changes
Apr 22, 2025
cynthiajoan
changed the title
Co-authored-by: Cynthia J <cynthiajoan@users.noreply.github.com>
Co-authored-by: Cynthia J <cynthiajoan@users.noreply.github.com>
natebosch
merged commit 73e4064
into
firebase:vertexai/developer_api
23 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move parsing from top level methods, and serialization from a method on
the model,into instance methods on a new
SerializationStrategyclass.Use the existing parsing code for the vertex strategy and copy over code
form the developer SDK for the Google AI strategy.
Add a
_ModelUriclass to allow a vertex and developer specializationfor the different backends.
Copy the serialization and parsing tests from the developer SDK, skip a
few tests that rely on arguments or methods that are unsupported in the
vertex model. Tests skipped for content embedding and extra arguments
passed to countTokens.