Skip to content

Fix: Disable tab swiping on NTP #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025
Merged

Fix: Disable tab swiping on NTP #6003

merged 6 commits into from
May 7, 2025

Conversation

0nko
Copy link
Member

@0nko 0nko commented May 2, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210046079393103?focus=true

Description

This PR fixes the tab swiping on NTP (disables it).

Steps to test this PR

Without favorites

  • Open a NTP
  • Try swiping the NTP content
  • Verify it doesn't work
  • Try swiping the omnibar or navigation bar
  • Verify the swiping works

With favorites

  • Open a NTP
  • Make sure you have at least 1 favorite bookmark
  • Try swiping the favorites area
  • Verify it doesn't work
  • Try dragging the bookmark
  • Verify the icon can be dragged and the tabs are not swiping

@0nko 0nko requested a review from malmstein as a code owner May 2, 2025 21:54
@CDRussell CDRussell self-assigned this May 7, 2025
Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as described. Only question is around whether this change can and should be feature flagged, if it's not already controlled?

@0nko 0nko requested a review from nalcalag as a code owner May 7, 2025 12:08
0nko added 3 commits May 7, 2025 14:18
# Conflicts:
#	app/src/test/java/com/duckduckgo/app/tabs/ui/TabSwitcherViewModelTest.kt
#	common/common-ui/src/main/java/com/duckduckgo/common/ui/tabs/SwipingTabsFeature.kt
@0nko 0nko force-pushed the fix/ondrej/ntp-tab-swiping branch from 8fed0ac to b8ff6c2 Compare May 7, 2025 13:31
@0nko 0nko merged commit b061ab8 into develop May 7, 2025
5 checks passed
@0nko 0nko deleted the fix/ondrej/ntp-tab-swiping branch May 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants