Support rendering URLs inside sync barcodes

[CDRussell]

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1209921184459923?focus=true

Description

Allows sync setup codes which appear in the QR barcode to be URL-based.

• Note, this is disabled by default.
• Note, this PR doesn’t handle scanning a URL-based barcode which will be in a higher branch on this stack.

Steps to test this PR

Get two devices (or one device + one emulator) as you’ll need to scan barcodes.

Feature disabled, everything works as normal

• The feature is disabled by default, so just fresh install the app from this branch on both devices
• For each of the following scenarios, make sure you can set up sync AND ensure that the “code to include” in logcat is NOT a URL:
  • Scanning barcode when both devices signed out
  • Scanning barcode when both devices signed in
  • Scanning barcode when scanning device is the only one signed out
  • Scanning barcode when scanning device is the only one signed in
  • Manually entering codes for the same scenarios…

Feature enabled

• Enable syncSetupBarcodeIsUrlBased feature flag on a device. Note, we expect the URL to be in the barcode but the other device won’t be able to scan it successfully (implemented in a higher branch on this stack) so don’t worry about that part.
• Repeat the scenarios above,
  • ensuring the barcode is a URL when showing the barcode (e.g., scan it from system camera app and inspect it). URL should match the spec from the tech design.
  • ensuring when manually sharing the code it does NOT use a URL

[CDRussell]

• Intercept sync setup URLs that are passed into our app #6008
• Support scanning URL-based sync setup codes #5957
• Support rendering URLs inside sync barcodes #5944 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cmonfortep]

LGTM

I would like to discuss if possible the responsibility of SyncBarcodeDecorator, and how feasible do you see moving the logic inside SyncAccountRepository. If you are ok and prefer to do it later in the stack, I'm fine with that.

[CDRussell]

how feasible do you see moving the logic inside SyncAccountRepository

Will take a look at this and ping back with thoughts

[cmonfortep]

All good, thanks for the addressing the comments 👍