Skip to content

Remove FeatureExceptions.Store and all its implementations #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Apr 7, 2025

Task/Issue URL: https://app.asana.com/0/1202552961248957/1209892744822628/f

Description

FeatureExceptions.Store interface as it's no longer necessary after adding getExceptions()
We'll need to remove the following classes

  • AutoconsentExceptionsStore
  • AutofillServiceExceptionsStore
  • MediaPlaybackStore
  • DrmBlockFeatureExceptionStore
  • MaliciousSiteProtectionExceptionsStore
  • AutofillSiteBreakageReportingExceptionsPersister
  • AutofillFeatureExceptionStore
  • EmailProtectionInContextRemoteExceptionsPersister

We'll need to refactor repositories associated to classes above

Steps to test this PR

Smoke test all features related to the stores above

Copy link
Collaborator Author

aitorvs commented Apr 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aitorvs aitorvs force-pushed the feature/aitor/ff/removeExceptionStores branch from 7c723e7 to 243fb2f Compare April 9, 2025 13:16
@aitorvs aitorvs marked this pull request as ready for review April 9, 2025 13:19
@aitorvs aitorvs force-pushed the feature/aitor/ff/removeExceptionStores branch 4 times, most recently from 8011d5c to 9b2da35 Compare April 15, 2025 17:20
@aitorvs aitorvs force-pushed the feature/aitor/ff/removeExceptionStores branch from 9b2da35 to 42a7c06 Compare April 22, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant