Skip to content

fix: added "application/octet-stream" to the "stl" mime type in the M… #9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Franky5831
Copy link

Description
I added the "application/octet-stream" to the "stl" mime type in the Mimes config class.
When I upload a stl file the mime type returns as "application/octet-stream" and the ext_in input validation returns false.
Reference issue: Issue: 9510.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link

mergeable bot commented Apr 28, 2025

Hi there, Franky5831! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

@Franky5831
Copy link
Author

I previously created this pull request but I closed since the commit wasn't verified and created this one.

@michalsn
Copy link
Member

Thank you. Please add a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.6.1.rst
Probably in the Changes section.

Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paulbalandan
Copy link
Member

Should the model/stl mime be added also as mentioned in the linked issue?

@michalsn
Copy link
Member

@paulbalandan Oh, you're right - I forgot about model/stl. It's listed in the IANA database, so we can safely rely on it.

@Franky5831 Can you add it to the config array and also mention it in the changelog?

@Franky5831
Copy link
Author

Sorry @michalsn I think I lost you, I created a pull request where I edited $mimes array from the app/Config/Mimes.php file, then I added the change to the v4.6.1.rst file for the changelog. What should I do?
Thanks

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I have in mind.

Franky5831 and others added 2 commits April 30, 2025 19:17
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@michalsn michalsn requested a review from paulbalandan April 30, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants