-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: added "application/octet-stream" to the "stl" mime type in the M… #9543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…imes config class
Hi there, Franky5831! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
I previously created this pull request but I closed since the commit wasn't verified and created this one. |
Thank you. Please add a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.6.1.rst |
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Should the |
@paulbalandan Oh, you're right - I forgot about @Franky5831 Can you add it to the config array and also mention it in the changelog? |
Sorry @michalsn I think I lost you, I created a pull request where I edited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what I have in mind.
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Description
I added the "application/octet-stream" to the "stl" mime type in the Mimes config class.
When I upload a stl file the mime type returns as "application/octet-stream" and the
ext_in
input validation returns false.Reference issue: Issue: 9510.
Checklist: