Skip to content

Enabling point range collector always if doc values not indexed #14559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jainankitk
Copy link
Contributor

Description

Enabling point range collector if doc values are not indexed

Resolves #14536

Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
@jpountz
Copy link
Contributor

jpountz commented Apr 28, 2025

I'd rather not do it. My mental model is that this collector works on doc values in the default case, and can opportunistically take advantage of index statistics or points indexes when it makes things faster. So doc values should be required, and index statistics and point indexes should be optional. Plus it would be confusing to me that the same collector would work or fail dependin on the specific query impl that is used, e.g. working with a PointRangeQuery on the same field (thanks to your other PR) but not on a PointRangeQuery on another field that has the same values for every doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Histogram Collection using PointTree when SortedNumericDocValues is absent
2 participants