Skip to content

Speed up flush of softdelete by intoBitset #14552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

gf2121
Copy link
Contributor

@gf2121 gf2121 commented Apr 24, 2025

Speed up the flush of softdelete by intoBitset.

relates: #14521

@gf2121 gf2121 marked this pull request as draft April 24, 2025 18:01
@gf2121
Copy link
Contributor Author

gf2121 commented Apr 25, 2025

I managed to get some numbers on this change:

Baseline: Soft delete flush total took: 30311ms, IndexedDISI#writeBitset total took: 8324ms.
Candidate: Soft delete flush total took: 22635ms, IndexedDISI#writeBitset total took: 964ms.

BTW, i added some docvalue fields in my benchmark. Then i'm seeing rather huge cost of virtual calls represented by vtable stub when computing min/max/gcd.

image

@gf2121 gf2121 marked this pull request as ready for review April 25, 2025 06:40
@gf2121
Copy link
Contributor Author

gf2121 commented Apr 28, 2025

I made some effort to simplify the change, this is ready for review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant