Skip to content

Fix scaleway doc #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix scaleway doc #6308

wants to merge 3 commits into from

Conversation

iaamp
Copy link

@iaamp iaamp commented Apr 16, 2025

This updates only the documentation (no code change) of the DNS plugin for Scaleway.

Seemingly there was a change in the API of Scaleway, and while it seems to previously have used an API Token, now it needs the Secret Key of an API Key.

We don't have to change the code here, as it works if just passing the SCW_SECRET_KEY as the existing argument. This is likely ideal, to not break anyones scripted setups.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@iaamp
Copy link
Author

iaamp commented Apr 16, 2025

I have read the guide. This PR does not change any code - only adds to the documentation.

@Neilpang
Copy link
Member

Any changes to the hook must be verified by the test.
Even if your chanage is only for doc, I would recommend you to finish the test. This is a good way to make sure the hook is still working by now.
Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants