Skip to content

Set up NX-based monorepo #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 406 commits into from
May 2, 2025
Merged

Set up NX-based monorepo #1773

merged 406 commits into from
May 2, 2025
+30,147 −35,097

Conversation

eliandoran
Copy link
Contributor

No description provided.

eliandoran added 30 commits April 22, 2025 10:09
@eliandoran
chore(nx): start off with a blank package.json
4f70084
@eliandoran
chore(nx): move .vscode extensions to old
a56b3c8
@eliandoran
chore(nx): initialize as empty project
57ecf72
@eliandoran
chore(nx): initialize empty commons project
84b6764
@eliandoran
chore(nx): prepare commons
41cf38a
@eliandoran
chore(nx): prepare turndown-plugin-gfm
a10a4ba
@eliandoran
chore(nx): create empty project for server
9c0d422
@eliandoran
chore(nx/server): move source code
b2af043
@eliandoran
chore(nx/server): switch to module
e76f47e
@eliandoran
chore(nx): remove unnecessary files
1cbf574
@eliandoran
chore(nx/server): manage dependencies
9dafaba
@eliandoran
chore(nx/server): remove empty file
462ed3c
@eliandoran
chore(monorepo/server): configure to work with top-level await
1c63fb7
@eliandoran
chore(monorepo): remove dist
e655963
@eliandoran
chore(monorepo/server): fix build errors due to wrong imports
6e35806
@eliandoran
chore(monorepo/server): remove top-level await completely
6543d6c
@eliandoran
chore(monorepo/server): fix db asset path
2aad162
@eliandoran
chore(nx/turndown-plugin): fix compilation
40fec89
@eliandoran
chore(nx/commons): fix compilation
b27ff1d
@eliandoran
chore(nx/server): add dependency to electron
2148714
@eliandoran
chore(nx/server): fix favicon
d5e1c5c
@eliandoran
chore(nx/server): fix api_docs_js_1.default.register is not a function
e817a55
@eliandoran
chore(monorepo/client): create empty project
23572bd
@eliandoran
chore(monorepo/client): move client source files
9afe2ef
@eliandoran
chore(monorepo/client): sync settings
70466dd
@eliandoran
chore(monorepo/client): set up dependencies
fa48e59
@eliandoran
chore(monorepo/client): set up stylesheets
eb6d802
@eliandoran
chore(monorepo/client): reintroduce script loader
aeeedea
@eliandoran
chore(nx/client): bypass module errors due to electron dependency
f2ade4e
@eliandoran
chore(nx/client): fix asset error
bcc908a
eliandoran added 15 commits May 1, 2025 17:22
@eliandoran
fix(edit-docs): get Electron to actually start
385182c
@eliandoran
chore(sign): log architecture of sign tool
9b2accb
@eliandoran
chore(sign): stop terminating signing if it fails
8f46116
@eliandoran
Merge remote-tracking branch 'origin/develop' into feature/nx_monorepo
c4b89f7
@eliandoran
chore(sign): clean up
04ed9c0
@eliandoran
Merge branch 'feature/nx_monorepo' of https://github.com/TriliumNext/…
d48face 
…Notes into feature/nx_monorepo
@eliandoran
chore(vs-code): extension recommandations
d388cfa
@eliandoran
chore(sign): fix import error
1f9ddce
@eliandoran
chore(sign): fix another import error
5596fa5
@eliandoran
chore(vs-code): i18n integration
1b2d769
@eliandoran
chore(monorepo): integrate some more files
18fff28
@eliandoran
chore(sign): change log format
ebab12d
@eliandoran
chore(sign): use sign code known to work
de2de04
@eliandoran
chore(monorepo): use hoisted pattern as it might help signing
762da51
@eliandoran
Revert "chore(monorepo): use hoisted pattern as it might help signing"
a97e110 
This reverts commit 762da51.
@deajan
Copy link
Member

deajan commented May 2, 2025

Hello, @deajan .

While doing some heavy refactoring on our code base I ran into the signing failing.

Hi @eliandoran

Sorry for the late reply. I have moved datacenter this weekend and as you can imagine, this ate quite some time.
Searching for the problem you encounter, I think I found the issue.
I compile the signing script so the keys don't get exposed, and I only compiled a 64 bit version.
Signing executables is not a problem, but for signing dlls, it will try to load them, and thus will fail when the arch doesn't correspond.
I can build a 32-bit signer too, but I have no clue whatsoever how to build (and run) an ARM signer.

Could you "send me" the offending file that needs to be signed so I can see what I can do ?

@eliandoran eliandoran mentioned this pull request May 2, 2025
Open
@eliandoran
Copy link
Contributor Author

@deajan , I've opened #1825 to track the issue with signing since it also occurs (silently) on develop.

@eliandoran eliandoran marked this pull request as ready for review May 2, 2025 17:54
@eliandoran eliandoran merged commit cfccf29 into develop May 2, 2025
14 checks passed
@eliandoran eliandoran deleted the feature/nx_monorepo branch May 2, 2025 17:54
@eliandoran eliandoran added this to the v0.94.0 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eliandoran @deajan