Skip to content

chore: refactor test data models #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 28, 2025
Merged

chore: refactor test data models #1552

merged 14 commits into from
Apr 28, 2025

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Apr 25, 2025

No description provided.

@zepfred zepfred requested a review from triceo April 25, 2025 15:22
triceo
triceo requested changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect any changes to assertions. Changes to assertions need to be explained first, except where:

  • the assertion changes because it references a package name.
  • the assertion changes compatibly (isEqualTo(0) v. isZero()).

It also looks like the Enterprise bits need an update.

@triceo triceo added this to the v1.23.0 milestone Apr 28, 2025
@triceo triceo removed this from the v1.23.0 milestone Apr 28, 2025
@triceo triceo linked an issue Apr 28, 2025 that may be closed by this pull request
Refactor test data models to reduce code duplication #1546
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@triceo triceo merged commit 3b36628 into TimefoldAI:main Apr 28, 2025
34 checks passed
@zepfred zepfred deleted the chore/duplicates branch April 28, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

Assignees

@zepfred zepfred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor test data models to reduce code duplication
2 participants
@zepfred @triceo