Skip to content

Bump PreallocationTools compat bound #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jClugstor
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Doesn't look like it improved the test it was supposed to fix?

@jClugstor
Copy link
Member Author

Yeah turns out this only fixes the specific case where the Dual tags are Nothing, but sometimes they're the OrdinaryDiffEqTag so the get_tmp still makes a ReinterpretedArray unfortunately. I think any mismatched tag is going to cause a ReinterpretedArray from get_tmp.

I think we'll need to use LBC with that in mind then.

@jClugstor jClugstor closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants