feat(ui5-shellbar): branding slot introduced #11320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already looks good, just a few stuff to talk about:
I know we talked to have the "primaryTitle/brandingTitle" as a slot, but now I'm rethinking, what if someone wants to have custom title later on, perhaps it could be better to "reserve" the slot for that and use a property now. We can have a call about this and decide. FYI, we decided to go with the "branding" name, so |
| * The `ui5-shellbar-branding` component is intended to be placed inside this slot. | ||
| * Content placed here takes precedence over the `primaryTitle` property and the `logo` content slot. | ||
| * | ||
| * @since 2.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
brandingslot has been introduced to theui5-shellbarcomponent.Additionally, a new component called
ui5-shellbar-brandinghas been added. This component combines a logo and a title, with the ability to open links. Its primary purpose is to be used within thebrandingslot, replacing the default primary title and logo of theui5-shellbar.The branding slot and its content take higher priority. As a result, if both the branding and the primary title + logo slot are used, only the
ui5-shellbar-brandingwill be displayed.