chore: add TodoMVC as example
#103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviio
force-pushed
the
chore/example
branch
3 times, most recently
from
0b0a6e0 to
4bb86ca
Compare
mr-pinzhang
reviewed
Jan 21, 2019
| import { source, TodoContext } from '../controller' | ||
| import { useObservable } from '../hooks' | ||
|
|
||
| export const Filter = React.memo(() => { |
There was a problem hiding this comment.
will there have any problem using React.memp with empty props?
There was a problem hiding this comment.
i think this should be ok, just like
shouldComponentUpdate() {
return false
}
|
can't tell differences between both, imo, the context only injects code inside component, which make it as a more coupled component. besides, no differences to me. |
|
@Saviio really hard to cr, could you post key changes as a snippet image? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这里还有一个分支：
https://github.com/ReactiveDB/core/tree/chore/example-v2
我已经分不清哪个 branch 更值得推荐了...
我的主要问题在于，怎么写 dispatcher，视图组件的划分逻辑，要不要用 context
P.S.
PR 的这个版本是使用了 context 的，建议 clone 下来 review