Skip to content

Sharding reshard supports mismatch parameter name #10467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Apr 23, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

New features

PR changes

Others

Description

Sharding reshard supports mismatch parameter name

Copy link

paddle-bot bot commented Apr 23, 2025

Thanks for your contribution!

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 10.20408% with 132 lines in your changes missing coverage. Please review.

Project coverage is 48.96%. Comparing base (f53e113) to head (f6aaa4f).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/sharding_io.py 10.34% 104 Missing ⚠️
paddlenlp/trainer/utils/reshard/common.py 6.89% 27 Missing ⚠️
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (10.20%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (48.96%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10467      +/-   ##
===========================================
- Coverage    48.99%   48.96%   -0.04%     
===========================================
  Files          765      765              
  Lines       125974   126087     +113     
===========================================
+ Hits         61720    61736      +16     
- Misses       64254    64351      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants