Skip to content

config type patch #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Mar 8, 2025

  • change config type from common to server to allow each save has its own config values
  • remove unused imports

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    idk

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    Config now will generate in saves/<world name>/serverconfig/ instead of a global instance locate at config/.
    Server location also changed to world/serverconfig/

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Yes, people need copy their configs to the serverconfig folder if they want use same config for their world.

  • Other information:
    change config type from common to server #703 (comment)

@SirEndii SirEndii added the 1.19x label May 1, 2025
@SirEndii SirEndii moved this to In progress in 0.8/1.0 Backlog May 1, 2025
@SirEndii SirEndii moved this from In progress to In review in 0.8/1.0 Backlog May 1, 2025
@SirEndii SirEndii added this to the 0.8r milestone May 1, 2025
@SirEndii SirEndii merged commit ef4d140 into IntelligenceModding:dev/0.8 May 1, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in 0.8/1.0 Backlog May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants