-
-
Notifications
You must be signed in to change notification settings - Fork 77
release/lite 1.19.2 #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/lite 1.19.2 #682
Conversation
only clear owner when new empty card is swapped but not after load
…dcast_if_possible Add `broadcast` option to the chat box
pull_request_target -> pull_request
I've started the game just to see what exactly is changed before I do a bigger code review (when I have more time) So you changed the modid, but not the name, do we ant to do that? And how do we want to version this. Should we stay at 0.7.38, should it begin at 0.7.0 or do we want a completely different versioning? So we would start at 0.1 or maybe directly 1.0 since the lite version would not contain any of the 0.8 features or other stuff |
And do we maybe want to release a 1.18.2 version too? |
Yes, this is uses for register chunk ticket, and be able to migrate easily |
I wants to see if 1.19.2 works well, and if it is then I can port it to 1.16-1.18. |
Just for easy management I'd keep the version same, but only bump the version if main branch is updating on related logics. And player will get same result for same version of mod Other mods should not dependent on the lite version mod, since its API may be removed/changed if its unnecessary. |
Alright I understand |
I'm dumb should use needs but not jobs Signed-off-by: Kevin Z <zyxkad@gmail.com>
…dvancedPeripherals into release/lite-1.19.2
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
…dvancedPeripherals into release/lite-1.19.2
Question here I at least can't give this any love for now, my highest priority is 1.21 and 0.8 |
Eh I thought you just reviewing it and forgot this XD. I don't think you said anything to reject this. Yes standard workflow will be enough. In fact, I think this is rarely going to update since currently we are focusing on mod integrations, which don't affect this at all.
Sure I can try maintain this, it shouldn't be too much work for me atm. |
@@ -21,7 +19,8 @@ | |||
@Mod(AdvancedPeripherals.MOD_ID) | |||
public class AdvancedPeripherals { | |||
|
|||
public static final String MOD_ID = "advancedperipherals"; | |||
public static final String MOD_ID = "advancedperipherals_lite"; | |||
public static final String ITEM_MOD_ID = "advancedperipherals"; | |||
public static final String NAME = "Advanced Peripherals"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to change this to Advanced Peripherals Lite
so it stuff like our creative menu also have the new name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we also want to change the line 31 where we log that AP is loading to the lite name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure, but you did not submit your review on January so I can't see them till now XD
e307fcd
into
IntelligenceModding:release/lite-1.19.2
Only kept vanilla integrations, chunky turtle & compass turtle