Skip to content

(fleet) simplify proxy configuration #29024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

arbll
Copy link
Member

@arbll arbll commented Apr 29, 2025

This PR simplifies our proxy documentation:

  • It splits out squid/haproxy/nginx examples to their own private pages
  • Rewrite of the main proxy documentation, with much less fluff and trivia, focusing on the golden path
  • Link out to examples, discouraging the use of nginx / haproxy

@arbll arbll requested a review from a team as a code owner April 29, 2025 08:54
@aliciascott
Copy link
Contributor

Created editorial card for our Agent SME to review further

@aliciascott aliciascott added the editorial review Waiting on a more in-depth review label Apr 29, 2025
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbll Few small comments but a great improvement!

@Yqnn Yqnn requested a review from Copilot April 30, 2025 09:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies our proxy documentation by splitting out proxy examples for Squid, HAProxy, and NGINX into their own dedicated pages and streamlining the main proxy documentation to focus on the golden path.

  • Introduces a new Squid proxy example with configuration instructions.
  • Adds a detailed NGINX proxy example with both HTTP and HTTPS configurations.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
content/en/agent/configuration/proxy_example_squid.md New Squid proxy example documentation with configuration details.
content/en/agent/configuration/proxy_example_nginx.md New NGINX proxy example documentation outlining both HTTP and HTTPS configurations and related Agent setup instructions.

logs_no_ssl: true
Forwarding traffic to Datadog using software like HAProxy or NGINX is **discouraged** because it requires you to manually configure and maintain the list of specific Datadog endpoints the Agent needs to reach.
This list can change, leading to potential data loss if not kept up-to-date. The only exception is if you need Deep Packet Inspection (DPI) capabilities, in which case you might consider using HAProxy or NGINX
as they allow you to drop disable TLS and inspect the traffic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
as they allow you to drop disable TLS and inspect the traffic.
as they can allow you to disable TLS or use your own TLS certificates and inspect the traffic.

This should be copy/pasted for the other ones too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants