-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore: implement new color tokens #7818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request implements new color tokens for the AppFlowy UI library. It updates the semantic color tokens for both light and dark themes, focusing on improving color usage and consistency across the UI. The changes include adjustments to text, border, fill, surface and icon colors, as well as the introduction of a badge color scheme. Additionally, it updates components such as buttons, text fields, and other UI elements to utilize the new color tokens. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richardshiue - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the now-unused color properties from the color scheme definitions.
- It looks like you've renamed
purple
tofeatured
- make sure this change makes sense in all contexts where the color is used. - Be sure to check that the changes to the button styles still look correct.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Implement new color tokens and refactor color schemes across the AppFlowy UI theme system
Enhancements:
Chores: