server adress log leads to error #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging an upstream repository into fork
Fixed error where server could not start since address was not defined propperly. (Maybe windows issue)
|
Ok. Need to double check it works on Mac/Linux |
thiagobustamante
suggested changes
Jul 11, 2018
| // TODO: replace with Morgan call | ||
| // tslint:disable-next-line:no-console | ||
| console.log(`Listening to http://${this.server.address().address}:${this.server.address().port}`); | ||
|
|
||
| console.log(`Listening to http://localhost:${address.port}`); |
There was a problem hiding this comment.
I think that would be better to print 'localhost' only if the address is undefined.
console.log(`Listening to http://${address.address? address.address:'localhost'}:${address.port}`);
vrudikov
reviewed
Mar 14, 2019
| // TODO: replace with Morgan call | ||
| // tslint:disable-next-line:no-console | ||
| console.log(`Listening to http://${this.server.address().address}:${this.server.address().port}`); | ||
|
|
||
| console.log(`Listening to http://localhost:${address.port}`); |
|
Can you try to reproduce, plz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not shure if it is a windows issue.
But I had to change the adress log since adress is not defined.
${this.server.address().address}