[Yosys][Warnings] Fixed Make Being Called With Multiple Threads #2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake was calling another Make command, but was explicitly passing the number of threads to use. Make files should not pass the number of threads to use since it may cause more threads to be consumed than what the user intended. For example, if the user used `make -j10`, the parent make would use 10 threads, and the child make would also use 10 threads; but this is not what the user wanted. I think CMake recognized this and was suppressing this behaviour anyways. I believe that CMake will pass the number of threads for the child make to use anyways, but in a way that would prevent the above issue. Removed the ability to set the number of threads for Yosys builds to handle the warning.
|
@vaughnbetz What do you think about this change? From researching the warning I found that it is bad practice to pass the "-j" argument to sub-makes (when your make file calls another make file) since this would double the number of threads used inadvertently; which is why the build was returning a warning. By removing the -j argument from the make call to the sub-make, the warning is resolved. See: |
|
Seems reasonable to me. @alirezazd @navidjafarof : any concerns with this change? |
|
@vaughnbetz LGTM |
|
@vaughnbetz No concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake was calling another Make command, but was explicitly passing the number of threads to use. Make files should not pass the number of threads to use since it may cause more threads to be consumed than what the user intended.
For example, if the user used
make -j10, the parent make would use 10 threads, and the child make would also use 10 threads (20 threads in total); but this is not what the user wanted. I think CMake recognized this and was suppressing this behaviour anyways. I believe that CMake will pass the number of threads for the child make to use anyways, but in a way that would prevent the above issue.Removed the ability to set the number of threads for Yosys builds to handle the warning.
See issue #2518