Skip to content

[TRI-5231] bug: Replaying in the dashboard and modifying an undefined value in the payload doesn't work #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt-aitken opened this issue Apr 23, 2025 · 0 comments

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Apr 23, 2025

If your original payload (coming from an SDK call you made) looks like this:

{ "foo":"bar","someKey": undefined }

You can’t use undefined in JSON but we use SuperJSON in the SDK so you can use Dates, undefined, Map and Set.

When you replay we show only valid JSON in the editor (our current editor doesn’t support SuperJSON). So it doesn't show someKey: undefined. In a lot of languages undefined and missing are the same, but not in JavaScript.

So if in the Replay editor you set this:

{ "foo":"bar","someKey": true }

But the payload of the run will actually be:

{ "foo":"bar","someKey": undefined }

This is a bug with editing a SuperJSON value that was already present in the original payload.

From SyncLinear.com | TRI-5231

@matt-aitken matt-aitken changed the title bug: Replaying in the dashboard and modifying an undefined value in the payload doesn't work [TRI-5231] bug: Replaying in the dashboard and modifying an undefined value in the payload doesn't work Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant