-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix -Zremap-path-scope
rmeta handling
#139550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR modifies cc @jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but I'm not an expert here and I'm wondering if it needs to be DEBUGINFO | DIAGNOSTICS
over just DEBUGINFO
.
4dcb816
to
4361d4f
Compare
After more investigation I was finally able to figure out the real issue, when we embed the paths in the This was done before I've added to @rustbot labels -S-blocked -S-waiting-on-author +S-waiting-on-review |
I don't have the capacity to properly review this right now and verify everything is correct. |
Esteban isn't that active rn afaik. |
4361d4f
to
7b89535
Compare
This PR fixes the conditional remapping (
-Zremap-path-scope
) of rmeta file pathsby using theby conditionally embedding the local path in addition to the remapped path.debuginfo
scopeFixes #139217