🎨 code optimization

Author: chfw

pyexcel_io/database/importers/django.py

@@ -47,22 +47,11 @@ def write_row(self, array):
 
     def close(self):
         if self.__bulk_save:
-            try:
-                self.__model.objects.bulk_create(
-                    self.__objs, batch_size=self.__batch_size)
-            except Exception as bulk_create_exception:
-                log.info(constants.MESSAGE_DB_EXCEPTION)
-                log.exception(bulk_create_exception)
-                raise
-
+            self.__model.objects.bulk_create(
+                self.__objs, batch_size=self.__batch_size)
         else:
             for an_object in self.__objs:
-                try:
-                    an_object.save()
-                except Exception as single_save_exception:
-                    log.info(constants.MESSAGE_IGNORE_ROW)
-                    log.exception(single_save_exception)
-                    raise
+                an_object.save()
 
 
 class DjangoBookWriter(BookWriter):

tests/test_base.py

@@ -19,25 +19,6 @@ def test_is_empty_array():
     assert is_empty_array(b) is False
 
 
-class ArrayReader(SheetReader):
-    @property
-    def name(self):
-        SheetReader.name
-        return self._native_sheet.name
-
-    def number_of_columns(self):
-        SheetReader.number_of_columns(self)
-        return len(self._native_sheet.payload[0])
-
-    def number_of_rows(self):
-        SheetReader.number_of_rows(self)
-        return len(self._native_sheet.payload)
-
-    def cell_value(self, row, column):
-        SheetReader.cell_value(self, row, column)
-        return self._native_sheet.payload[row][column]
-
-
 class ArrayWriter(SheetWriter):
     def set_sheet_name(self, name):
         self._native_sheet.name = name