Skip to content

Commit 8e81c7d

Browse files
committed
Removing constructor tests
Removing all tests that creates a new instance but doesn't call any methods nor preform any assertions.
1 parent 82dc5be commit 8e81c7d

6 files changed

+0
-53
lines changed

Tests/CalculateRootJobStatusProcessorTest.php

-13
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,6 @@
1717

1818
class CalculateRootJobStatusProcessorTest extends \PHPUnit\Framework\TestCase
1919
{
20-
/**
21-
* @doesNotPerformAssertions
22-
*/
23-
public function testCouldBeConstructedWithRequiredArguments()
24-
{
25-
new CalculateRootJobStatusProcessor(
26-
$this->createJobStorageMock(),
27-
$this->createCalculateRootJobStatusCaseMock(),
28-
$this->createProducerMock(),
29-
$this->createLoggerMock()
30-
);
31-
}
32-
3320
public function testShouldReturnSubscribedTopicNames()
3421
{
3522
$this->assertEquals(

Tests/CalculateRootJobStatusServiceTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,6 @@
99

1010
class CalculateRootJobStatusServiceTest extends \PHPUnit\Framework\TestCase
1111
{
12-
/**
13-
* @doesNotPerformAssertions
14-
*/
15-
public function testCouldBeConstructedWithRequiredArguments()
16-
{
17-
new CalculateRootJobStatusService($this->createJobStorageMock());
18-
}
19-
2012
public function stopStatusProvider()
2113
{
2214
return [

Tests/DependentJobContextTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@
77

88
class DependentJobContextTest extends \PHPUnit\Framework\TestCase
99
{
10-
/**
11-
* @doesNotPerformAssertions
12-
*/
13-
public function testCouldBeConstructedWithRequiredArguments()
14-
{
15-
new DependentJobContext(new Job());
16-
}
17-
1810
public function testShouldReturnJob()
1911
{
2012
$job = new Job();

Tests/DependentJobServiceTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@
1010

1111
class DependentJobServiceTest extends \PHPUnit\Framework\TestCase
1212
{
13-
/**
14-
* @doesNotPerformAssertions
15-
*/
16-
public function testCouldBeConstructedWithRequiredArguments()
17-
{
18-
new DependentJobService($this->createJobStorageMock());
19-
}
20-
2113
public function testShouldThrowIfJobIsNotRootJob()
2214
{
2315
$job = new Job();

Tests/Doctrine/JobStorageTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@
1515

1616
class JobStorageTest extends \PHPUnit\Framework\TestCase
1717
{
18-
/**
19-
* @doesNotPerformAssertions
20-
*/
21-
public function testCouldBeConstructedWithRequiredArguments()
22-
{
23-
new JobStorage($this->createDoctrineMock(), 'entity-class', 'unique_table');
24-
}
25-
2618
public function testShouldCreateJobObject()
2719
{
2820
$repository = $this->createRepositoryMock();

Tests/JobProcessorTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@
1313

1414
class JobProcessorTest extends TestCase
1515
{
16-
/**
17-
* @doesNotPerformAssertions
18-
*/
19-
public function testCouldBeCreatedWithRequiredArguments()
20-
{
21-
new JobProcessor($this->createJobStorage(), $this->createProducerMock());
22-
}
23-
2416
public function testCreateRootJobShouldThrowIfOwnerIdIsEmpty()
2517
{
2618
$processor = new JobProcessor($this->createJobStorage(), $this->createProducerMock());

0 commit comments

Comments
 (0)