-
Notifications
You must be signed in to change notification settings - Fork 363
chore(docs): use static values in demos #11769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview: https://patternfly-react-pr-11769.surge.sh A11y report: https://patternfly-react-pr-11769-a11y.surge.sh |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make a similar update to the TimestampBasicFormats example file
@Mash707 for now we could just update those random values in the PaginatedTable file itself |
@thatblindgeye There are 25 entries for this example https://www.patternfly.org/patterns/right-to-left/react-demos/paginated-table/, this would make the source code pretty big with unnecessary information. Let me know what you think |
45b61dd
to
a511304
Compare
@Mash707 Ah yeah fair, may not hurt to have a separate file for that data then |
a511304
to
3020895
Compare
@thatblindgeye regarding this example I have few things to clarify:
|
Closes #11768