Support monitor multiple install path simultaneously #88
Conversation
|
I tried this out and it works great for me, connected simultaneously with VS Code and Cursor. |
|
Ditto, works for Cursor, Thank you! |
|
Ditto. That is awesome. |
There was a problem hiding this comment.
LGTM apart from this.
The mismatch between the sentence and behavior should be addressed one way or another, but I have no strong opinion on on which way: that would depend on whether it is ok to make such breaking changes in general in the nix ecosystem, which I don't consider myself to have strong knowledge about. Perhaps the best option would be to first work but display a warning, and only then in a future release remove the support for the only-str case?
README.md
Outdated
| @@ -140,11 +140,11 @@ This same list is also used to determine the `RPATH` when automatically patching | |||
| ``` | |||
|
|
|||
| ### `installPath` | |||
| The installation path for VS Code server is configurable and the default can differ for alternative builds (e.g. oss and insider), so this option allows you to configure which installation path should be monitered and automatically fixed. | |||
| The installation path for VS Code server is configurable and the default can differ for alternative builds (e.g. oss and insider), so this option allows you to configure which installation path should be monitered and automatically fixed. If you have multiple installations, you can specify them as an array. | |||
There was a problem hiding this comment.
This seems to suggest that it's optional to specify them as an array, but AFAICT the old writing with a single value wouldn't match the option's type anymore.
There was a problem hiding this comment.
I have updated the options to accept either a list of str or a bare str, using coercedTo.
|
Any updates on this getting merged? |
Currently, we can only set one installPath, but what if we use vscode, vscode-insiders, cursor simultaneously? So, this pr add the support for specifying multiple install path.