Skip to content

Disable the "fps_limit= <value>" command #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
ffsxecu opened this issue Apr 3, 2025 · 9 comments
Open
1 task done

Disable the "fps_limit= <value>" command #4139

ffsxecu opened this issue Apr 3, 2025 · 9 comments
Labels
enhancement New feature or request

Comments

@ffsxecu
Copy link

ffsxecu commented Apr 3, 2025

Is your feature request related to a problem? Please describe.

Players can manually set their FPS limit using the "fps_limit=45" command. This becomes an issue on servers that enforce a maximum of 100 FPS, players can lower this limit and gain an unfair advantage.
Also its possible to change the FPS limit in the MTA/config/coreconfig.xml.

Describe the solution you'd like

Add a server-side option that allows server owners to disable or control the fps_limit command.

Describe alternatives you've considered

No response

Additional context

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
@ffsxecu ffsxecu added the enhancement New feature or request label Apr 3, 2025
@sacr1ficez
Copy link
Contributor

sacr1ficez commented Apr 4, 2025

Let's say you will block the command, but what will stop players from using NVIDIA control panel FPS limiter, or any other limiter software, or even artifically dropping their FPS by running some stuff in background? I assume you mean vehicle handling, which got fixes in past (such as #2784), but got reverted after all due to backwards compatibility.

@ffsxecu
Copy link
Author

ffsxecu commented Apr 4, 2025

Let's say you will block the command, but what will stop players from using NVIDIA control panel FPS limiter, or any other limiter software, or even artifically dropping their FPS by running some stuff in background? I assume you mean vehicle handling, which got fixes in past (such as #2784), but got reverted after all due to backwards compatibility.

It makes no sense to not allow disabling this default MTA command when there are servers that don't allow programs that affect FPS such as Bandicam and Rivatuner. I should also point out that its easily binded on servers with maximum FPS values ​​and spammed with minimum FPS values, and abused by players on non-ghostmode servers.

@sacr1ficez
Copy link
Contributor

Perhaps, but in my opinion you should aim for real fixes (not some half measures), such as the one i've mentioned before.

@PlatinMTA
Copy link
Contributor

I dont think there is a way to stop people from playing with lower FPS, period. Why don't you try to check via code the FPS of a player? Or better yet, try to fix the underlying issue with playing with lower FPS.

That being said, I don't think we should add an option to disable this, rather, the fps_limit CVAR shouldnt allow values that are less than 100, so it should only allow 0, or 100+, which should be an easy fix. This won't stop the underlying issue tho.

@Lpsd
Copy link
Member

Lpsd commented Apr 4, 2025

I agree with others - even adding this as an optional feature doesn't resolve your problem entirely, as external programs can easily be used (even Nvidia control panel itself).

Measure the FPS in clientside script, tell them to get a better PC or remove frame-limiter. There is your overall workaround to the underlying problem of framerate dependent game mechanics.

The real solution is obviously fixing those framerate discrepancies.

@Lpsd
Copy link
Member

Lpsd commented Apr 4, 2025

It's kind of strange to see how we've gone from a general culture of telling everyone to limit their FPS to 48 or whatever the standard used to be (in order to prevent issues), to now saying you can't play if you don't reach 100. What kind of experience is that?

@ffsxecu
Copy link
Author

ffsxecu commented Apr 4, 2025

Well... you guys giving an answer that is far from the main topic. Just as the maximum FPS value can be set by the server owner, the minimum value should also be set. Yes, its still possible to manipulate the FPS with applications such as Nvidia etc., but this answer you gave is still irrelevant to the topic. Nobody is saying to anyone "If you don't have 100 FPS, you can't play". What is actually stated is to ensure that this command can also be controlled by the server.

@Lpsd
Copy link
Member

Lpsd commented Apr 4, 2025

You're trying to fix the symptom, not the cause.

The real solution is obviously fixing those framerate discrepancies.

When your proposed solution is implemented, what happens to all the players with weak hardware who can only get 45 FPS on a good day?

What is stopping people from using their old PC to play on your server to get the toptimes (or whatever advantage you are inferring), when fps_limit usage is disabled clientside?

@FXME
Copy link

FXME commented Apr 14, 2025

I reviewed #2784 and ran some tests, and I find it strange that this fix hasn't been fully implemented in MTA. Vehicles actually behave properly at high FPS — there's practically no difference between 100 FPS and 1000 FPS.

The only noticeable bug is the strong jolts and jumps of the vehicle when shifting gears. I believe that if this bug is fixed and the developers are reminded about it, the fix will likely make it into the main build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants