CDRIVER-5956 raise min wire version from 7 to 8 (server 4.2) #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove behavior and tests that only run on server <= 4.0.
Test is only expected to run on server >=4.0 and <4.0.7.
The "not primary" error does not cause the connection to be closed in > 4.0. Expect a `killCursors` command is sent on resume.
Test requires server < 4.0.7
Tests are expected to run on all supported server versions.
Expect `killCursors` command on non-network error to avoid delay in `mongoc_cursor_destroy`.
vector-of-bool
approved these changes
Apr 24, 2025
mdb-ad
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Verified with this patch build.
Removing no-longer-needed cursor implementations is not done in this PR and planned for CDRIVER-4722.
Auth tests using the test server are temporarily skipped until the test server is upgraded. Upgrading is tracked in DEVPROD-9029.
Added
killCursorsin testsSome tests that destroy cursors (
test_change_stream_resumable_error) are updated to reflect behavior for server > 4.0. Quoting SDAM:Previously the connection was closed after error. With the connection persisting, destroying the cursor sends
killCursors. Tests are updated to expect to sendkillCursorswhen destroying a cursor with a non-zero cursor ID and open connection.