fix: improve uncaught exception for getAccessToken

[blva]

• improves send events to make it clearer when we send auth/unauth
• adds one more test

[Copilot]

Pull Request Overview

This PR improves the handling of access tokens when sending telemetry events by making the failure mode more explicit and introducing a new test to cover the fallback logic.

• Updated test descriptions and behavior to simulate token errors more clearly.
• Renamed method hasValidAccessToken to validateAccessToken and updated its usage across the codebase.
• Modified the sendEvents logic to catch errors and fall back to an unauthenticated endpoint when needed.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/unit/apiClient.test.ts	Updated tests to reflect the new exception-based token failure behavior.
tests/integration/helpers.ts	Modified to use validateAccessToken instead of hasValidAccessToken.
src/server.ts	Updated API client method call for token validation.
src/common/atlas/apiClient.ts	Replaced token validation method and revised sendEvents to check token state.

Comments suppressed due to low confidence (1)

src/common/atlas/apiClient.ts:145

• Throwing a generic Error here may make it harder to distinguish token-related failures from other errors. Consider using a specific error type (e.g., ApiClientError) for better error handling and consistency.

if (!accessToken) { throw new Error("No access token available"); }

[gagik]

not sure if I got it right but this can end up just not finding the access token right? so it'd effectively not validate it always?

[blva]

it validates if it exists otherwise it will just return undefined, which is fine