TDX: Configure MSR intercepts for VTL 1, refactor MSR intercepts in general #1251
+118
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way for us to add inspection for these fields so we can know what MSR bits are set? |
|
It's just part of the VMCS, so it'd be covered by #1119 |
|
Fine, but someone should probably tackle that one soon. |
chris-oo
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the MSR bitmap struct since we were never storing it anywhere, just set MSR bits with individual calls. This is simpler and uses less stack space, but slightly less efficient since we now make more vmcs writes overall, but since these are cold paths with a small number of calls I think this tradeoff is worthwhile. Then update intercept registration to set the required bits.