ref(grouping): Add split enhancements to enhancement bases #90557
+23
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is currently blocked by getsentry/ophio#73, which in turn is blocked by getsentry/ophio#72. Once those are merged, it will fix the failing test.
This is a follow-up to #90505, which enabled enhancements (stacktrace rules) to be split up into classifier and contribtues types. In this PR, such split enhancements are added the default enhancements objects (the "bases," the ones representing the rules from each grouping config), to live alongside the regular enhancements, by forcing them to be created using version 3, rather than version 2.
This means that now if non-default enhancements were to be instantiated with version 3, their split rust enhancements would actually pull in the real default rules, rather than the empty rules provided by the
classifier_rust_enhancements
andcontributes_rust_enhancements
class variables. Nothing is actually doing that right now, but this means that once we turn it on, it'll have the right data.This PR also adds some magic methods to the
EnhancementRule
class, to make testing easier.