Skip to content

Commit 04a4924

Browse files
committed
Stabilize integration test
1 parent d2969f9 commit 04a4924

File tree

1 file changed

+46
-43
lines changed

1 file changed

+46
-43
lines changed

api-client/src/test/java/de/gesellix/docker/remote/api/client/ImageApiIntegrationTest.java

+46-43
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,42 @@
11
package de.gesellix.docker.remote.api.client;
22

3+
import static de.gesellix.docker.remote.api.testutil.Constants.LABEL_KEY;
4+
import static de.gesellix.docker.remote.api.testutil.Constants.LABEL_VALUE;
5+
import static java.util.Arrays.asList;
6+
import static java.util.Collections.singletonList;
7+
import static java.util.Collections.singletonMap;
8+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
9+
import static org.junit.jupiter.api.Assertions.assertEquals;
10+
import static org.junit.jupiter.api.Assertions.assertFalse;
11+
import static org.junit.jupiter.api.Assertions.assertNotNull;
12+
import static org.junit.jupiter.api.Assertions.assertTrue;
13+
14+
import java.io.ByteArrayInputStream;
15+
import java.io.ByteArrayOutputStream;
16+
import java.io.File;
17+
import java.io.IOException;
18+
import java.io.InputStream;
19+
import java.net.InetSocketAddress;
20+
import java.net.URL;
21+
import java.nio.file.Files;
22+
import java.nio.file.Paths;
23+
import java.time.Duration;
24+
import java.time.temporal.ChronoUnit;
25+
import java.util.ArrayList;
26+
import java.util.HashMap;
27+
import java.util.List;
28+
import java.util.Map;
29+
import java.util.Optional;
30+
import java.util.concurrent.CountDownLatch;
31+
import java.util.concurrent.TimeUnit;
32+
33+
import org.junit.jupiter.api.BeforeEach;
34+
import org.junit.jupiter.api.Test;
35+
import org.slf4j.Logger;
36+
import org.slf4j.LoggerFactory;
37+
338
import com.squareup.moshi.Moshi;
39+
440
import de.gesellix.docker.builder.BuildContextBuilder;
541
import de.gesellix.docker.registry.DockerRegistry;
642
import de.gesellix.docker.remote.api.BuildInfo;
@@ -25,40 +61,6 @@
2561
import de.gesellix.docker.remote.api.testutil.TestImage;
2662
import de.gesellix.testutil.ResourceReader;
2763
import okio.Okio;
28-
import org.junit.jupiter.api.BeforeEach;
29-
import org.junit.jupiter.api.Test;
30-
import org.slf4j.Logger;
31-
import org.slf4j.LoggerFactory;
32-
33-
import java.io.ByteArrayInputStream;
34-
import java.io.ByteArrayOutputStream;
35-
import java.io.File;
36-
import java.io.IOException;
37-
import java.io.InputStream;
38-
import java.net.InetSocketAddress;
39-
import java.net.URL;
40-
import java.nio.file.Files;
41-
import java.nio.file.Paths;
42-
import java.time.Duration;
43-
import java.time.temporal.ChronoUnit;
44-
import java.util.ArrayList;
45-
import java.util.HashMap;
46-
import java.util.List;
47-
import java.util.Map;
48-
import java.util.Optional;
49-
import java.util.concurrent.CountDownLatch;
50-
import java.util.concurrent.TimeUnit;
51-
52-
import static de.gesellix.docker.remote.api.testutil.Constants.LABEL_KEY;
53-
import static de.gesellix.docker.remote.api.testutil.Constants.LABEL_VALUE;
54-
import static java.util.Arrays.asList;
55-
import static java.util.Collections.singletonList;
56-
import static java.util.Collections.singletonMap;
57-
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
58-
import static org.junit.jupiter.api.Assertions.assertEquals;
59-
import static org.junit.jupiter.api.Assertions.assertFalse;
60-
import static org.junit.jupiter.api.Assertions.assertNotNull;
61-
import static org.junit.jupiter.api.Assertions.assertTrue;
6264

6365
@DockerEngineAvailable
6466
class ImageApiIntegrationTest {
@@ -115,14 +117,13 @@ public void onFinished() {
115117
}
116118
};
117119
assertDoesNotThrow(() -> imageApi.imageBuild(Paths.get(dockerfile).getFileName().toString(), "test:build", null, null, null, null, null, null,
118-
null, null, null, null, null, null, null,
119-
null, null, null, null, null, null, null,
120-
null, null, null, null, buildContext,
121-
callback, timeout.toMillis()));
120+
null, null, null, null, null, null, null,
121+
null, null, null, null, null, null, null,
122+
null, null, null, null, buildContext,
123+
callback, timeout.toMillis()));
122124
try {
123125
latch.await(2, TimeUnit.MINUTES);
124-
}
125-
catch (InterruptedException e) {
126+
} catch (InterruptedException e) {
126127
log.error("Wait interrupted", e);
127128
}
128129

@@ -260,9 +261,11 @@ public void imageLoad() {
260261
assertDoesNotThrow(() -> imageApi.imageLoad(false, tarFile));
261262

262263
List<String> actualRepoDigests = imageApi.imageInspect("test:load-image").getRepoDigests();
263-
assertEquals(originalRepoDigests, actualRepoDigests);
264-
265-
imageApi.imageDelete("test:load-image", null, null);
264+
try {
265+
assertEquals(originalRepoDigests, actualRepoDigests);
266+
} finally {
267+
imageApi.imageDelete("test:load-image", null, null);
268+
}
266269
}
267270

268271
@Test

0 commit comments

Comments
 (0)