Skip to content

Commit 72354bb

Browse files
authored
fix(ui5-button): update parameters according to VD (#11414)
With this change we update the font-family parameters in the <ui5-button> component in order to be compliant with the VD Specifications. Ref: BGSOFUIBALKAN-9197
1 parent 54389b5 commit 72354bb

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

packages/main/src/themes/Button.css

+4-4
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ bdi {
231231
border-color: var(--sapButton_Emphasized_BorderColor);
232232
border-width: var(--_ui5_button_emphasized_border_width);
233233
color: var(--sapButton_Emphasized_TextColor);
234-
font-family: var(--sapFontBoldFamily );
234+
font-family: var(--sapButton_Emphasized_FontFamily);
235235
}
236236

237237
/*The ui5_hovered class is set by FileUploader to indicate hover state of the control*/
@@ -306,7 +306,7 @@ bdi {
306306
/* Button with badge */
307307
::slotted([slot="badge"][design="InlineText"]) {
308308
pointer-events: initial;
309-
font-family: "72override", var(--sapFontFamily);
309+
font-family: "72override", var(--sapButton_FontFamily);
310310
font-size: var(--sapFontSmallSize);
311311
padding-inline-start: 0.25rem;
312312
--_ui5-tag-height: 0.625rem;
@@ -319,7 +319,7 @@ bdi {
319319
inset-inline-end: 0;
320320
margin: -0.5rem;
321321
z-index: 1000;
322-
font-family: "72override", var(--sapFontFamily);
322+
font-family: "72override", var(--sapButton_FontFamily);
323323
font-size: var(--sapFontSmallSize);
324324
--_ui5-tag-height: 0.625rem;
325325
}
@@ -336,5 +336,5 @@ bdi {
336336

337337
:host(:state(has-overlay-badge)) {
338338
overflow: visible;
339-
margin-right: 5px;
339+
margin-inline-end: 0.3125rem;
340340
}

packages/main/src/themes/ButtonBadge.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
:host([design="AttentionDot"]) [ui5-tag]::part(root) {
1212
min-width: var(--_ui5-button-badge-diameter);
13-
min-height: var(--_ui5-button-badge-diameter);
14-
height: var(--_ui5-button-badge-diameter);
13+
min-height: var(--_ui5-button-badge-diameter);
14+
height: var(--_ui5-button-badge-diameter);
1515
width: var(--_ui5-button-badge-diameter);
1616
border-radius: 100%;
1717
}

packages/main/src/themes/base/Button-parameters.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
--_ui5_button_focus_offset: 1px;
1818
--_ui5_button_focus_width: 1px;
1919
--_ui5_button_pressed_focused_border_color: var(--sapContent_ContrastFocusColor);
20-
--_ui5_button_fontFamily: var(--sapFontFamily);
20+
--_ui5_button_fontFamily: var(--sapButton_FontFamily);
2121
--_ui5_button_emphasized_focused_border_color: var(--sapButton_Emphasized_BorderColor);
2222
--_ui5_button_emphasized_focused_border_before: 0.125rem solid var(--sapContent_FocusColor);
2323
--_ui5_button_emphasized_focused_active_border_color: transparent;

packages/main/src/themes/sap_horizon/Button-parameters.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
--_ui5_button_text_shadow: none;
1313
--_ui5_button_emphasized_border_width: .0625rem;
1414
--_ui5_button_pressed_focused_border_color: var(--sapContent_FocusColor);
15-
--_ui5_button_fontFamily: var(--sapFontSemiboldDuplexFamily);
15+
--_ui5_button_fontFamily: var(--sapButton_FontFamily);
1616
--_ui5_button_emphasized_focused_border_color: var(--sapContent_ContrastFocusColor);
1717
}

packages/main/src/themes/sap_horizon_dark/Button-parameters.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313
--_ui5_button_emphasized_border_width: .0625rem;
1414
--_ui5_button_pressed_focused_border_color: var(--sapContent_FocusColor);
1515
--_ui5_button_emphasized_focused_border_color: var(--sapContent_ContrastFocusColor);
16-
--_ui5_button_fontFamily: var(--sapFontSemiboldDuplexFamily);
16+
--_ui5_button_fontFamily: var(--sapButton_FontFamily);
1717
}

0 commit comments

Comments
 (0)